Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Instrumentation Examples to Contrib Repository #5783

Conversation

ysolomchenko
Copy link
Contributor

Fixes #5526

Changes

Migrate demo/examples related to instrumentation form main to contrib repository.
In this PR

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@github-actions github-actions bot added the documentation Documentation related label Aug 12, 2024
@cijothomas
Copy link
Member

@ysolomchenko Thanks for the PR. I am unsure how is this related to moving instrumentation libraries to contrib repo... The examples are not just instrumentation libraries and they would work equally well without instrumentation libraries as well.

Though I agree that the examples currently need some rethinking, given the docs directory is covering this somewhat, and this has lot of duplication with that.

Copy link
Contributor

This PR was marked stale due to lack of activity and will be closed in 7 days. Commenting or pushing will instruct the bot to automatically remove the label. This bot runs once per day.

@github-actions github-actions bot added the Stale Issues and pull requests which have been flagged for closing due to inactivity label Aug 20, 2024
Copy link
Contributor

Closed as inactive. Feel free to reopen if this PR is still being worked on.

@github-actions github-actions bot closed this Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation related Stale Issues and pull requests which have been flagged for closing due to inactivity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move remaining instrumentation libraries to the opentelemetry-dotnet-contrib repo
2 participants