Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instrumentation examples from main repo #2003

Conversation

ysolomchenko
Copy link
Contributor

Fixes open-telemetry/opentelemetry-dotnet#5526

Changes

Migrate demo/examples related to instrumentation form main to contrib repository.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@ysolomchenko ysolomchenko marked this pull request as ready for review August 12, 2024 13:19
@ysolomchenko ysolomchenko requested a review from a team August 12, 2024 13:19
Copy link
Member

@cijothomas cijothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned in the main repo PR, we need to decide what is the plan for these examples before moving them as-is.

There are lot of valuable information in the examples, that is not shown elsewhere. So its worth discussing and having a full plan to decide what to do with examples.

@ysolomchenko ysolomchenko marked this pull request as draft August 14, 2024 10:45
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Aug 22, 2024
Copy link
Contributor

Closed as inactive. Feel free to reopen if this PR is still being worked on.

@github-actions github-actions bot closed this Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move remaining instrumentation libraries to the opentelemetry-dotnet-contrib repo
2 participants