Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Instrumentation.SqlClient] Move to contrib repository #5559

Merged
merged 2 commits into from
Apr 24, 2024

Conversation

Kielek
Copy link
Contributor

@Kielek Kielek commented Apr 22, 2024

Towards: #5526
Related to: open-telemetry/opentelemetry-dotnet-contrib#1673

Changes

[Instrumentation.SqlClient] Move to contrib repository

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • [ ] Appropriate CHANGELOG.md files updated for non-trivial changes
  • [ ] Changes in public API reviewed (if applicable)

@Kielek
Copy link
Contributor Author

Kielek commented Apr 24, 2024

Pull request in the contrib repository already merged.

Copy link

codecov bot commented Apr 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.46%. Comparing base (6250307) to head (682a459).
Report is 191 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5559      +/-   ##
==========================================
+ Coverage   83.38%   85.46%   +2.08%     
==========================================
  Files         297      282      -15     
  Lines       12531    12216     -315     
==========================================
- Hits        10449    10441       -8     
+ Misses       2082     1775     -307     
Flag Coverage Δ
unittests ?
unittests-Instrumentation-Experimental 83.95% <ø> (?)
unittests-Instrumentation-Stable 83.87% <ø> (?)
unittests-Solution-Experimental 85.39% <ø> (?)
unittests-Solution-Stable 85.22% <ø> (?)
unittests-Unstable-Core 19.87% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 80 files with indirect coverage changes

Co-authored-by: Reiley Yang <[email protected]>
@CodeBlanch CodeBlanch merged commit 98a5d3e into open-telemetry:main Apr 24, 2024
57 checks passed
@Kielek Kielek deleted the drop-sqlclient branch April 24, 2024 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants