-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Instrumentation.SqlClient] Move package from main repository #1673
[Instrumentation.SqlClient] Move package from main repository #1673
Conversation
Open questions
@open-telemetry/dotnet-approvers? |
ce07b4d
to
1cc0734
Compare
1cc0734
to
9fbfdf2
Compare
Probably not necessary IMHO. I think including the opentelemetry-dotnet PR link in the commit description is important though.
Not a blocker, leave it as empty for now, folks who have knowledge/experience + are willing to be the owner can claim it in separate PRs. |
// Copyright The OpenTelemetry Authors | ||
// SPDX-License-Identifier: Apache-2.0 | ||
|
||
#pragma warning disable IDE0005 // Using directive is unnecessary.using System; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
curious why do we need additional using? original file does not have it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Upstream - all usages have enable ImplicitUsings
. In this repository, this file is also part of OpenTelemetry.Contrib.Tests.Shared
. This feature is not enabled so I have to add it manually, but the SqlClient project enables Implicitusings
- it requiers additional #pragma disable.
...lemetry.Instrumentation.SqlClient.Tests/OpenTelemetry.Instrumentation.SqlClient.Tests.csproj
Show resolved
Hide resolved
</ItemGroup> | ||
|
||
<ItemGroup> | ||
<PackageReference Include="Microsoft.Extensions.Options" Version="$(MicrosoftExtensionsOptionsPkgVer)" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is downgrading the version to 3.1.0?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. Handled in 0cf5262.
We should consider unifying Microsoft.Extensions.Options
version in this repository. Candidate for separate PR.
9becd2f
to
c2fd7e0
Compare
Towards open-telemetry/opentelemetry-dotnet#5526
Changes
Please provide a brief description of the changes here.
For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes