Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove OpenTelemetry.SemanticConventions project #5539

Conversation

reyang
Copy link
Member

@reyang reyang commented Apr 16, 2024

Follow up #5531 (comment).
If users find the project useful, might be a good fit for the opentelemetry-dotnet-contrib repo.

Copy link

codecov bot commented Apr 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.54%. Comparing base (6250307) to head (94ab88d).
Report is 179 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5539      +/-   ##
==========================================
+ Coverage   83.38%   85.54%   +2.16%     
==========================================
  Files         297      289       -8     
  Lines       12531    12605      +74     
==========================================
+ Hits        10449    10783     +334     
+ Misses       2082     1822     -260     
Flag Coverage Δ
unittests ?
unittests-Solution-Experimental 85.54% <ø> (?)
unittests-Solution-Stable 85.51% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 77 files with indirect coverage changes

Copy link
Member

@alanwest alanwest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I suggested we drop this project in the SIG meeting. Almost pushed up my branch and opened this PR... guess you beat me to it 😆

@alanwest
Copy link
Member

I just unlisted the package from NuGet... should stop showing in search results shortly.

@CodeBlanch CodeBlanch merged commit 1fb00d9 into open-telemetry:main Apr 16, 2024
32 checks passed
@CodeBlanch
Copy link
Member

What is the urgency here? What we talked about on the SIG was we would land #5531 and then do this as a follow-up. Now I have to go sort out conflicts. Are we practicing good professional courtesy? What sort of collaborative environment do we want to foster?

@reyang reyang deleted the reyang/remove-OpenTelemetry.SemanticConventions-project branch April 16, 2024 20:55
@reyang
Copy link
Member Author

reyang commented Apr 17, 2024

What is the urgency here? What we talked about on the SIG was we would land #5531 and then do this as a follow-up. Now I have to go sort out conflicts. Are we practicing good professional courtesy? What sort of collaborative environment do we want to foster?

Are these questions for me?

@reyang
Copy link
Member Author

reyang commented Apr 17, 2024

What are the real motivations behind this change?

Maintenance - this package should not come from the opentelemetry-dotnet repository, opentelemetry-dotnet is only intended for core components such as the API / SDK / plugins required by the specification / infrastructure components.

If there is high demand, opentelemetry-dotnet-contrib is the right place #5539 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants