-
Notifications
You must be signed in to change notification settings - Fork 773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove OpenTelemetry.SemanticConventions project #5539
Remove OpenTelemetry.SemanticConventions project #5539
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5539 +/- ##
==========================================
+ Coverage 83.38% 85.54% +2.16%
==========================================
Files 297 289 -8
Lines 12531 12605 +74
==========================================
+ Hits 10449 10783 +334
+ Misses 2082 1822 -260
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 I suggested we drop this project in the SIG meeting. Almost pushed up my branch and opened this PR... guess you beat me to it 😆
I just unlisted the package from NuGet... should stop showing in search results shortly. |
What is the urgency here? What we talked about on the SIG was we would land #5531 and then do this as a follow-up. Now I have to go sort out conflicts. Are we practicing good professional courtesy? What sort of collaborative environment do we want to foster? |
Are these questions for me? |
Maintenance - this package should not come from the opentelemetry-dotnet repository, opentelemetry-dotnet is only intended for core components such as the API / SDK / plugins required by the specification / infrastructure components. If there is high demand, opentelemetry-dotnet-contrib is the right place #5539 (comment). |
Follow up #5531 (comment).
If users find the project useful, might be a good fit for the opentelemetry-dotnet-contrib repo.