-
Notifications
You must be signed in to change notification settings - Fork 773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[repo] Define release process for unstable core components #5531
[repo] Define release process for unstable core components #5531
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5531 +/- ##
==========================================
+ Coverage 83.38% 85.65% +2.27%
==========================================
Files 297 289 -8
Lines 12531 12605 +74
==========================================
+ Hits 10449 10797 +348
+ Misses 2082 1808 -274
Flags with carried forward coverage won't be shown. Click here to find out more. |
build/RELEASING.md
Outdated
@@ -5,6 +5,16 @@ Only for Maintainers. | |||
1. Decide the tag name (version name) to be released. e.g. 1.4.0-beta.1, | |||
1.0.0-rc9.7 etc. | |||
|
|||
Notes: | |||
|
|||
* Instrumentation packages are core unstable packages always depend on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vishweshbankwar when can these packages move to contrib repo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should be able to move them: #5526. Looking for help.
build/RELEASING.md
Outdated
* `core-`: Core packages. These packages are defined\goverened by the | ||
OpenTelemetry Specification and have released stable versions. They |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this statement true? For example
Line 7 in 1fb00d9
<MinVerTagPrefix>core-</MinVerTagPrefix> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pushed updates to try and make everything clear (and to address the below two comments). Please check it out and LMK what you think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Closes #5530
Changes
publish-packages
workflow pass the tag to builds asPackTag
and only package projects which matchMinVerTagPrefix
.coreunstable-
withrc
or stable.PackageValidationBaselineVersion
.Merge requirement checklist