Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve metrics docs - part 2 #5284

Merged
merged 20 commits into from
Jan 31, 2024
Merged

Improve metrics docs - part 2 #5284

merged 20 commits into from
Jan 31, 2024

Conversation

reyang
Copy link
Member

@reyang reyang commented Jan 30, 2024

Follow up #5279.

@reyang reyang requested a review from a team January 30, 2024 01:24
@reyang reyang changed the title Improve metrics docs Improve metrics docs - part 2 Jan 30, 2024
@reyang reyang marked this pull request as draft January 30, 2024 01:28
rajkumar-rangaraj
rajkumar-rangaraj approved these changes Jan 30, 2024
View reviewed changes
Copy link
Contributor

@rajkumar-rangaraj rajkumar-rangaraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We may need to add a note in /metrics/getting-started-console/README.md mentioning that this sample uses the using keyword, which disposes of the object once its context is lost.

@reyang
Copy link
Member Author

reyang commented Jan 30, 2024

LGTM. We may need to add a note in /metrics/getting-started-console/README.md mentioning that this sample uses the using keyword, which disposes of the object once its context is lost.

Which one uses "using" keyword?

@rajkumar-rangaraj
Copy link
Contributor

Which one uses "using" keyword?

Please ignore, it is not related to this PR, it requires a change in another readme. I will send a PR separately.

cijothomas
cijothomas reviewed Jan 31, 2024
View reviewed changes
docs/metrics/README.md Outdated Show resolved Hide resolved
cijothomas
cijothomas reviewed Jan 31, 2024
View reviewed changes
docs/metrics/README.md Outdated Show resolved Hide resolved
@reyang reyang marked this pull request as ready for review January 31, 2024 20:35
@reyang
Copy link
Member Author

reyang commented Jan 31, 2024

Which one uses "using" keyword?

Please ignore, it is not related to this PR, it requires a change in another readme. I will send a PR separately.

I found two docs and fixed both of them in this PR.

cijothomas
cijothomas reviewed Jan 31, 2024
View reviewed changes
docs/metrics/README.md Outdated Show resolved Hide resolved
cijothomas
cijothomas reviewed Jan 31, 2024
View reviewed changes
docs/metrics/README.md Outdated Show resolved Hide resolved
reyang and others added 4 commits January 31, 2024 13:31
@reyang @cijothomas
Update docs/metrics/README.md
3b21e77 
Co-authored-by: Cijo Thomas <[email protected]>
@reyang @vishweshbankwar
Update docs/metrics/README.md
348d1d4 
Co-authored-by: Vishwesh Bankwar <[email protected]>
@reyang @vishweshbankwar
Update docs/metrics/README.md
7f2384e 
Co-authored-by: Vishwesh Bankwar <[email protected]>
@reyang @vishweshbankwar
Update docs/metrics/README.md
f2e8556 
Co-authored-by: Vishwesh Bankwar <[email protected]>
@CodeBlanch CodeBlanch added documentation Documentation related metrics Metrics signal related labels Jan 31, 2024
@CodeBlanch CodeBlanch merged commit 0ee3eb1 into open-telemetry:main Jan 31, 2024
17 checks passed
@reyang reyang deleted the reyang/metrics-docs-part2 branch January 31, 2024 22:42
@reyang reyang mentioned this pull request Feb 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cijothomas cijothomas cijothomas left review comments

@vishweshbankwar vishweshbankwar vishweshbankwar approved these changes

@rajkumar-rangaraj rajkumar-rangaraj rajkumar-rangaraj approved these changes

Assignees
No one assigned
Labels
documentation Documentation related metrics Metrics signal related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@reyang @rajkumar-rangaraj @cijothomas @vishweshbankwar @CodeBlanch