Improve metrics docs #5279
Merged
Improve metrics docs #5279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reyang
commented
Jan 29, 2024
|
@CodeBlanch CI failure seems to be related to incorrect rule? https://github.com/open-telemetry/opentelemetry-dotnet/actions/runs/7702940578/job/20992314129?pr=5279 |
|
@reyang Not sure what's up with that markdownlint failure and why it is popping up all of a sudden. I noticed it here: https://github.com/open-telemetry/opentelemetry-dotnet/actions/runs/7701990497/job/20993415110?pr=5255#step:4:14. I'm currently looking into it, standby. Update... Opened this PR to revert to the previous version of markdownlint: #5281 @alanwest Told me offline he'll try to figure out why those files don't work with latest (v15) when he has some cycles. |
cijothomas
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(in the next PR I plan to cover memory considerations, aggregation temporality and cardinality)