-
Notifications
You must be signed in to change notification settings - Fork 784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[repo] Bump Microsoft.Extensions.Logging.Configuration and clean up net462 targets #5020
[repo] Bump Microsoft.Extensions.Logging.Configuration and clean up net462 targets #5020
Conversation
Codecov Report
@@ Coverage Diff @@
## main #5020 +/- ##
==========================================
+ Coverage 83.39% 83.41% +0.01%
==========================================
Files 296 296
Lines 12403 12403
==========================================
+ Hits 10344 10346 +2
+ Misses 2059 2057 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
<ItemGroup> | ||
<Reference Include="System.Net.Http" Condition="'$(TargetFramework)' == '$(NetFrameworkMinimumSupportedVersion)'" /> | ||
</ItemGroup> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this change?
Looks like this wasn't included before.
https://www.nuget.org/packages/OpenTelemetry.Instrumentation.Http/1.6.0-beta.2#dependencies-body-tab
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good eye there @TimothyMothra! Not totally sure. This baffled me and @utpilla a bit. We used to reference the 3.1 versions of these packages. Interestingly they have a netstandard2.0
target but NOT a net462
target. We are jumping to the .NET 8 RC versions which do have a net462
target. For some reason, using that new dedicated net462
target a bunch of these projects started complaining about missing System.Net.Http
! My theory is that HttpClient
is part of netstandard2.0
but NOT net462
. It seems like when the netstandard2.0
bits were used the whole .NET Standard 2.0 API layer came with it including HttpClient
. Best guess 😆 If you want to spend some time on it and try to figure it out I am very curious to know exactly what is going on but I decided not enough so to keep spending time on it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Relates to #5015
Changes
'$(TargetFrameworkIdentifier)' == '.NETCoreApp'
style in more places.Merge requirement checklist
CHANGELOG.md
files updated for non-trivial changes