-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix build errors #1488
Fix build errors #1488
Conversation
<Reference Include="System.Net.Http" Condition="'$(TargetFramework)' == '$(NetFrameworkMinimumSupportedVersion)'" /> | ||
</ItemGroup> | ||
--> | ||
<PackageReference Include="System.Net.Http" Version="4.3.4" Condition="'$(TargetFramework)' == 'net462'" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With 1.7.0
version of the SDK, this package now pulls in 8.0.0
version of Microsoft.Extensions.Logging.Configuration
instead of 3.1.0
version that used to come with the previous dependency.
Microsoft.Extensions.Logging.Configuration
has added a dedicated net462 target in 8.0.0
which does not have the System.Net.Http
assembly included. That's why we need an explicit package dependency for net462
targets now. With 3.1.0
version, there was no dedicated net462
target, and the package ended up using netstandard2.0
bits which includes the System.Net.Http
assembly.
Follow this discussion for more details: open-telemetry/opentelemetry-dotnet#5020 (comment)
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1488 +/- ##
==========================================
+ Coverage 73.91% 81.83% +7.91%
==========================================
Files 267 124 -143
Lines 9615 3451 -6164
==========================================
- Hits 7107 2824 -4283
+ Misses 2508 627 -1881
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I have the same fixes on #1487 but I can merge these in.
Changes