Add enrichment & filter for http client metrics #4889
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hayhay27
force-pushed
the
httpclient-metrics-enrichment
branch
from
a3965f6 to
fe8a089
Compare
hayhay27
force-pushed
the
httpclient-metrics-enrichment
branch
from
fe8a089 to
f0da9eb
Compare
|
#4374 Please see the existing PR that never was merged. Adding this require some design discussions to make sure everyone is aligned. |
|
This PR was marked stale due to lack of activity and will be closed in 7 days. Commenting or Pushing will instruct the bot to automatically remove the label. This bot runs once per day. |
github-actions
bot
added
the
Stale
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
|
Why this PR is closed? I don't see this feaure in the current "AddAspNetCoreInstrumentation()" metrics implementation. |
See open-telemetry/opentelemetry-dotnet-contrib#1733 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes open-telemetry/opentelemetry-dotnet-contrib#1775
Design discussion issue #
Changes
Ability to filter and enrich http client metrics
AddHttpClientInstrumentationaccepts configuration delegateHttpClientMetricInstrumentationOptionsis public now and has two new properties (returning delegates) -FilterandEnrichMerge requirement checklist
CHANGELOG.mdfiles updated for non-trivial changes