Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enrich support for HttpClientMetrics #1775

Open
alexarchen opened this issue Jul 12, 2022 · 2 comments
Open

Enrich support for HttpClientMetrics #1775

alexarchen opened this issue Jul 12, 2022 · 2 comments
Labels
comp:instrumentation.http Things related to OpenTelemetry.Instrumentation.Http enhancement New feature or request

Comments

@alexarchen
Copy link

The best way to add urls into HttpClientMetrics is to use Enrich possibility so that subscriber can select meaningful part of request by himself.
Alternative way is to use the list of possible endpoints that url can match => tag is the name of endpoint.
Filter is also desirable

@alexarchen alexarchen added the enhancement New feature or request label Jul 12, 2022
@aunikitin
Copy link

Hello, I made MR. Does it the same?

@martinjt
Copy link
Member

martinjt commented Jun 2, 2024

High-Cardinality data such as URL shouldn't go into metrics.

That said, enrichment support was something to look at once the stable releases were out. @CodeBlanch is now the time to look at this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment