[Instrumentation.Http] Support for enrich and filter delegates for http client metric #4148
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I'd like to have an opportunity to enrich metrics with custom logic (for example uri templates of requested paths). Also I add opportunity to filter some requests because of TODO in
MeterProviderBuilderExtensions
I tried to use existing
HttpClientInstrumentationOptions
but firstly, they have too mutch for metrics and secondly, because in theHttpHandlerMetricsDiagnosticListener
we are not allowed to take tags from activity (because of uncontrolled source of filling), that's why delegates in settings don't fit .Also I wrote some tests and did small refactoring in them (move trace tests in one file; split configuration tests from common, because they don't need running
HttpListener
).If my changes are admissible, I will add description to
CHANGELOG.md
.Probably it resolves issue
Changes
Please provide a brief description of the changes here.
For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes