Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue of multiple instances of OpenTelemetry-Instrumentation EventSource being created #4720

Merged

Conversation

utpilla
Copy link
Contributor

@utpilla utpilla commented Jul 28, 2023

Similar to #4586

We have multiple projects that link to InstrumentationEventSource which could cause users to run into the error: An instance of EventSource with Guid {guid} already exists. These components should use their own dedicated EventSource events.

Changes

  • Removed IntrumentationEventSource
  • Update the instrumentation libraries to use their own EventSource events

@utpilla utpilla requested a review from a team July 28, 2023 02:54
@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

Merging #4720 (62d007d) into main (ce1e196) will decrease coverage by 0.03%.
The diff coverage is 67.74%.

❗ Current head 62d007d differs from pull request most recent head e2a5cd9. Consider uploading reports for the commit e2a5cd9 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4720      +/-   ##
==========================================
- Coverage   85.14%   85.11%   -0.03%     
==========================================
  Files         314      313       -1     
  Lines       12722    12746      +24     
==========================================
+ Hits        10832    10849      +17     
- Misses       1890     1897       +7     
Files Changed Coverage Δ
...ementation/AspNetCoreInstrumentationEventSource.cs 70.00% <40.00%> (-10.00%) ⬇️
...t/Implementation/GrpcInstrumentationEventSource.cs 53.84% <40.00%> (-8.66%) ⬇️
...p/Implementation/HttpInstrumentationEventSource.cs 70.00% <40.00%> (-6.00%) ⬇️
...cSourceInstrumentation/DiagnosticSourceListener.cs 66.66% <66.66%> (+2.38%) ⬆️
...umentation.AspNetCore/AspNetCoreInstrumentation.cs 100.00% <100.00%> (ø)
...ry.Instrumentation.AspNetCore/AspNetCoreMetrics.cs 100.00% <100.00%> (ø)
...ntation.GrpcNetClient/GrpcClientInstrumentation.cs 100.00% <100.00%> (ø)
....Instrumentation.Http/HttpClientInstrumentation.cs 100.00% <100.00%> (ø)
...elemetry.Instrumentation.Http/HttpClientMetrics.cs 100.00% <100.00%> (ø)
...trumentation.SqlClient/SqlClientInstrumentation.cs 100.00% <100.00%> (ø)
... and 1 more

... and 5 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants