Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue of multiple instances of OpenTelemetry-Instrumentation EventSource being created #1362

Merged

Conversation

Kielek
Copy link
Contributor

@Kielek Kielek commented Sep 20, 2023

Propagate changes from open-telemetry/opentelemetry-dotnet#4720

Changes

Fix issue of multiple instances of OpenTelemetry-Instrumentation EventSource being created when using more than one instrumentation for Quartz, ElasitcSearch. EF Core.
IncludeSharedDiagnosticSourceSubscriber property to include Shared internal class DiagnosticSourceSubscriber into compilation.

For significant contributions please make sure you have completed the following items:

  • Appropriate CHANGELOG.md updated for non-trivial changes
  • [ ] Design discussion issue #
  • [ ] Changes in public API reviewed

@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Merging #1362 (ef84458) into main (71655ce) will increase coverage by 0.15%.
Report is 6 commits behind head on main.
The diff coverage is 77.27%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1362      +/-   ##
==========================================
+ Coverage   73.91%   74.07%   +0.15%     
==========================================
  Files         267      258       -9     
  Lines        9615     9484     -131     
==========================================
- Hits         7107     7025      -82     
+ Misses       2508     2459      -49     
Flag Coverage Δ
unittests 79.88% <77.27%> (?)
unittests-Exporter.Geneva 58.13% <ø> (?)
unittests-Exporter.OneCollector 89.71% <ø> (?)
unittests-Instrumentation.Process 100.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage
...Implementation/QuartzInstrumentationEventSource.cs 0.00%
...ntation/ElasticsearchInstrumentationEventSource.cs 16.66%
...searchClient/ElasticsearchClientInstrumentation.cs 100.00%
...ityFrameworkCore/EntityFrameworkInstrumentation.cs 100.00%
...ation/EntityFrameworkInstrumentationEventSource.cs 100.00%
...ation.Owin/Implementation/DiagnosticsMiddleware.cs 100.00%
....Owin/Implementation/OwinInstrumentationMetrics.cs 100.00%
...inInstrumentationMeterProviderBuilderExtensions.cs 100.00%
...Instrumentation.Quartz/QuartzJobInstrumentation.cs 100.00%

Copy link
Contributor

@ejsmith ejsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a nice improvement

Co-authored-by: Utkarsh Umesan Pillai <[email protected]>
@utpilla utpilla merged commit f1d1939 into open-telemetry:main Sep 20, 2023
1 check failed
@Kielek Kielek deleted the duplicated-InstrumentationEventSource branch September 20, 2023 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants