-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue of multiple instances of OpenTelemetry-Instrumentation EventSource being created #1362
Merged
utpilla
merged 5 commits into
open-telemetry:main
from
Kielek:duplicated-InstrumentationEventSource
Sep 20, 2023
Merged
Fix issue of multiple instances of OpenTelemetry-Instrumentation EventSource being created #1362
utpilla
merged 5 commits into
open-telemetry:main
from
Kielek:duplicated-InstrumentationEventSource
Sep 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tSource being created
Codecov Report
@@ Coverage Diff @@
## main #1362 +/- ##
==========================================
+ Coverage 73.91% 74.07% +0.15%
==========================================
Files 267 258 -9
Lines 9615 9484 -131
==========================================
- Hits 7107 7025 -82
+ Misses 2508 2459 -49
Flags with carried forward coverage won't be shown. Click here to find out more. |
ejsmith
approved these changes
Sep 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a nice improvement
utpilla
reviewed
Sep 20, 2023
...nstrumentation.ElasticsearchClient/Implementation/ElasticsearchInstrumentationEventSource.cs
Outdated
Show resolved
Hide resolved
utpilla
reviewed
Sep 20, 2023
src/OpenTelemetry.Instrumentation.Quartz/Implementation/QuartzInstrumentationEventSource.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Utkarsh Umesan Pillai <[email protected]>
utpilla
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Propagate changes from open-telemetry/opentelemetry-dotnet#4720
Changes
Fix issue of multiple instances of OpenTelemetry-Instrumentation EventSource being created when using more than one instrumentation for Quartz, ElasitcSearch. EF Core.
IncludeSharedDiagnosticSourceSubscriber
property to include Shared internal class DiagnosticSourceSubscriber into compilation.For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes[ ] Design discussion issue #[ ] Changes in public API reviewed