Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor test exporters, use instead DelegatingTestExporter #3486

Merged
merged 12 commits into from
Aug 2, 2022
Merged

refactor test exporters, use instead DelegatingTestExporter #3486

merged 12 commits into from
Aug 2, 2022

Conversation

TimothyMothra
Copy link
Contributor

@TimothyMothra TimothyMothra commented Jul 25, 2022

Pulling changes out of #3476.

Here I'm refactoring DelegatingTestExporter to enable additional test scenarios.
Currently DelegatingTestExporter is coded for a specific scenario, recording ExportResults and performing an optional configured Action.
This change makes the entire Export configurable with OnExportFunc.

The other PR will build on this by adding additional configurable methods.

Changes

  • refactor DelegatingTestExporter to be more flexible for additional test scenarios.
    (I'll expand on this in my other PR).

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • Appropriate CHANGELOG.md updated for non-trivial changes
  • Design discussion issue #
  • Changes in public API reviewed

@TimothyMothra TimothyMothra requested a review from a team July 25, 2022 18:05
@TimothyMothra TimothyMothra changed the title refactor test exporters, using DelegatingTestExporter refactor test exporters, use instead DelegatingTestExporter Jul 25, 2022
@codecov
Copy link

codecov bot commented Jul 25, 2022

Codecov Report

Merging #3486 (269189a) into main (5a327df) will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3486      +/-   ##
==========================================
+ Coverage   86.73%   86.76%   +0.03%     
==========================================
  Files         275      275              
  Lines        9963     9963              
==========================================
+ Hits         8641     8644       +3     
+ Misses       1322     1319       -3     
Impacted Files Coverage Δ
...emetry.Api/Internal/OpenTelemetryApiEventSource.cs 76.47% <0.00%> (-5.89%) ⬇️
...metryProtocol/Implementation/ActivityExtensions.cs 95.60% <0.00%> (+1.09%) ⬆️
src/OpenTelemetry/Logs/OpenTelemetryLogger.cs 91.11% <0.00%> (+2.22%) ⬆️
...ter.ZPages/Implementation/ZPagesActivityTracker.cs 100.00% <0.00%> (+2.85%) ⬆️
...ZPages/Implementation/ZPagesExporterEventSource.cs 62.50% <0.00%> (+6.25%) ⬆️

Copy link
Member

@cijothomas cijothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cijothomas cijothomas merged commit a1cdb28 into open-telemetry:main Aug 2, 2022
@TimothyMothra TimothyMothra deleted the refactor_test_exporters branch August 2, 2022 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants