-
Notifications
You must be signed in to change notification settings - Fork 790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor test exporters, use instead DelegatingTestExporter
#3486
Merged
cijothomas
merged 12 commits into
open-telemetry:main
from
TimothyMothra:refactor_test_exporters
Aug 2, 2022
Merged
refactor test exporters, use instead DelegatingTestExporter
#3486
cijothomas
merged 12 commits into
open-telemetry:main
from
TimothyMothra:refactor_test_exporters
Aug 2, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DelegatingTestExporter
DelegatingTestExporter
Codecov Report
@@ Coverage Diff @@
## main #3486 +/- ##
==========================================
+ Coverage 86.73% 86.76% +0.03%
==========================================
Files 275 275
Lines 9963 9963
==========================================
+ Hits 8641 8644 +3
+ Misses 1322 1319 -3
|
utpilla
reviewed
Jul 28, 2022
utpilla
approved these changes
Jul 28, 2022
Kielek
approved these changes
Jul 29, 2022
utpilla
approved these changes
Jul 29, 2022
reyang
reviewed
Aug 2, 2022
reyang
approved these changes
Aug 2, 2022
reyang
reviewed
Aug 2, 2022
test/OpenTelemetry.Exporter.OpenTelemetryProtocol.Tests/IntegrationTests.cs
Outdated
Show resolved
Hide resolved
reyang
reviewed
Aug 2, 2022
cijothomas
approved these changes
Aug 2, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulling changes out of #3476.
Here I'm refactoring
DelegatingTestExporter
to enable additional test scenarios.Currently
DelegatingTestExporter
is coded for a specific scenario, recordingExportResults
and performing an optional configuredAction
.This change makes the entire Export configurable with
OnExportFunc
.The other PR will build on this by adding additional configurable methods.
Changes
DelegatingTestExporter
to be more flexible for additional test scenarios.(I'll expand on this in my other PR).
Please provide a brief description of the changes here.
For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes