improve code coverage: BaseExporter, BaseProcessor, PooledList, SamplingResult, SimpleExportProcessor, TracerProviderExtensions, MathHelper, and WildcardHelper
#3476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reyang
reviewed
Jul 22, 2022
Codecov Report
@@ Coverage Diff @@
## main #3476 +/- ##
==========================================
+ Coverage 86.37% 87.26% +0.88%
==========================================
Files 275 275
Lines 9959 9948 -11
==========================================
+ Hits 8602 8681 +79
+ Misses 1357 1267 -90
|
reyang
previously requested changes
Jul 22, 2022
@reyang I made changes to |
3 tasks
TimothyMothra
changed the title
BaseExporter, BaseProcessor, PooledList, SamplingResult, SimpleExportProcessor, and WildcardHelperBaseExporter, BaseProcessor, PooledList, SamplingResult, SimpleExportProcessor, TracerProviderExtensions, and WildcardHelper
TimothyMothra
changed the title
BaseExporter, BaseProcessor, PooledList, SamplingResult, SimpleExportProcessor, TracerProviderExtensions, and WildcardHelperBaseExporter, BaseProcessor, PooledList, SamplingResult, SimpleExportProcessor, TracerProviderExtensions, MathHelper, and WildcardHelper
cijothomas
reviewed
Aug 4, 2022
| // Verify that the Processor catches and suppresses the exception. | ||
| testSimpleExportProcessor.OnEnd(new object()); | ||
|
|
||
| // verify Exporter OnExport wall called. |
There was a problem hiding this comment.
Suggested change
| // verify Exporter OnExport wall called. | |
| // verify Exporter OnExport was called. |
utpilla
reviewed
Aug 4, 2022
| public void Verify_ForceFlush_HandlesException() | ||
| { | ||
| // By default, ForceFlush should return true. | ||
| var testExporter = new DelegatingExporter<object>(); |
There was a problem hiding this comment.
Is this actually testing the "default" return value of BaseExporter<T>.ForceFlush()? This would test what DelegatingExporter.OnForceFlushFunc returns.
utpilla
reviewed
Aug 4, 2022
| { | ||
| // By default, ForceFlush should return true. | ||
| var testExporter = new DelegatingExporter<object>(); | ||
| Assert.True(testExporter.Shutdown()); |
There was a problem hiding this comment.
Same concern as the previous comment.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #3353
As of today:
Changes
DelegatingExportorto enable more test scenarios.DelegatingProcessorPlease provide a brief description of the changes here.
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes