Remove net461 support from API and SDK #3191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reyang
approved these changes
Apr 15, 2022
Codecov Report
@@ Coverage Diff @@
## main #3191 +/- ##
==========================================
+ Coverage 85.25% 85.31% +0.06%
==========================================
Files 259 258 -1
Lines 9330 9315 -15
==========================================
- Hits 7954 7947 -7
+ Misses 1376 1368 -8
|
mic-max
approved these changes
Apr 15, 2022
| <PropertyGroup> | ||
| <Description>Unit test project for OpenTelemetry</Description> | ||
| <!-- OmniSharp/VS Code requires TargetFrameworks to be in descending order for IntelliSense and analysis. --> | ||
| <TargetFrameworks>net6.0;net5.0;netcoreapp3.1</TargetFrameworks> | ||
| <TargetFrameworks Condition="$(OS) == 'Windows_NT'">$(TargetFrameworks);net461</TargetFrameworks> | ||
| <TargetFrameworks Condition="$(OS) == 'Windows_NT'">$(TargetFrameworks);net462</TargetFrameworks> |
There was a problem hiding this comment.
Should we update the workflows now or will that be a seperate PR?
opentelemetry-dotnet/.github/workflows/windows-ci.yml
Lines 17 to 19 in 503d2b0
There was a problem hiding this comment.
yea will do in follow ups.
…ijothomas/opentelemetry-dotnet into cijothomas/removenet461_apisdk
reyang
approved these changes
Apr 15, 2022
TimothyMothra
approved these changes
Apr 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #3190
Will do separate PRs for other projects, this one just deals with API/SDK and Docs.