Skip to content
This repository has been archived by the owner on Jul 25, 2024. It is now read-only.

Try exporter with latest version of OTel .NET SDK #37

Merged
merged 7 commits into from
Jan 17, 2023

Conversation

joaopgrassi
Copy link
Member

@joaopgrassi joaopgrassi commented Jan 11, 2023

  • Bump the version of the Utils to address issue with numbers being serialized with wrong culture
  • Add note recomending users to update to OTel SDK 1.3.1 or higher to avoid the bug found in the SDK
  • Update sample/tests to use SDK/Exporter version 1.3.2
  • Some small improvements in the README
  • Verified that the included samples work when the app uses a higher version of the OTel SDK (1.3.2) than what is shipped with our library (1.2.0)

Update with the target SDK used in the exporter and added usings statements to snippets to make it easier for trying things out.
Copy link
Member

@pirgeo pirgeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried it out, everything still seems to work!

README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
@joaopgrassi joaopgrassi changed the title Update the .NET OTel SDK to 1.3.2 Try exporter with latest version of OTel .NET SDK Jan 12, 2023
@joaopgrassi joaopgrassi requested a review from pirgeo January 12, 2023 10:28
Updated Utils library and added test to ensure numbers are properly serialized with an invariant culture.
@joaopgrassi joaopgrassi merged commit d153961 into main Jan 17, 2023
@joaopgrassi joaopgrassi deleted the update-otel-sdk-latest branch January 17, 2023 08:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants