-
Notifications
You must be signed in to change notification settings - Fork 769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rely on DefaultResource's Service.Name for Exporters #1768
Merged
cijothomas
merged 20 commits into
open-telemetry:main
from
Austin-Tan:ExportersGrabDefaultResource
Feb 2, 2021
Merged
Rely on DefaultResource's Service.Name for Exporters #1768
cijothomas
merged 20 commits into
open-telemetry:main
from
Austin-Tan:ExportersGrabDefaultResource
Feb 2, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Austin-Tan
commented
Feb 1, 2021
cijothomas
reviewed
Feb 1, 2021
cijothomas
reviewed
Feb 1, 2021
… in jaeger, this undoes that
Codecov Report
@@ Coverage Diff @@
## main #1768 +/- ##
==========================================
+ Coverage 84.16% 84.19% +0.02%
==========================================
Files 187 187
Lines 5931 5934 +3
==========================================
+ Hits 4992 4996 +4
+ Misses 939 938 -1
|
cijothomas
reviewed
Feb 2, 2021
…y-dotnet into ExportersGrabDefaultResource
cijothomas
reviewed
Feb 2, 2021
cijothomas
reviewed
Feb 2, 2021
cijothomas
reviewed
Feb 2, 2021
CodeBlanch
approved these changes
Feb 2, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
cijothomas
approved these changes
Feb 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #1744.
Changes
Previous PR #1744 changed Default Resource to comply by spec's service.name requirement. This PR will apply this to all applicable exporters.
For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes