Skip to content

Commit

Permalink
IsAllDataRequested true after ending (#1758)
Browse files Browse the repository at this point in the history
* IsAllDataRequested true after ending

* false typo

* Make it clear in comment that we are no marking IsAlLDataRequested as false
  • Loading branch information
cijothomas authored Feb 2, 2021
1 parent 4b14247 commit 7d8c403
Showing 1 changed file with 8 additions and 0 deletions.
8 changes: 8 additions & 0 deletions src/OpenTelemetry/Trace/TracerProviderSdk.cs
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,14 @@ internal TracerProviderSdk(
return;
}

// Spec says IsRecording must be false once span ends.
// https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/api.md#isrecording
// However, Activity has slightly different semantic
// than Span and we don't have strong reason to do this
// now, as Activity anyway allows read/write always.
// Intentionally commenting the following line.
// activity.IsAllDataRequested = false;

if (SuppressInstrumentationScope.DecrementIfTriggered() == 0)
{
this.processor?.OnEnd(activity);
Expand Down

0 comments on commit 7d8c403

Please sign in to comment.