Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Exporter.Geneva] Enable nullable globally #2190

Merged
merged 11 commits into from
Oct 16, 2024
Merged

[Exporter.Geneva] Enable nullable globally #2190

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
293b389
Draft nullable support in the main proj
IliaBrahinets Aug 22, 2024
0a677c7
Nullable in geneva exporter
IliaBrahinets Oct 8, 2024
ed8cfc9
Merge branch 'main' into nullable-exporter-geneva
IliaBrahinets Oct 8, 2024
9e534d4
FIx nullable warnings
IliaBrahinets Oct 8, 2024
eab6647
Remove file-level nullable directive
IliaBrahinets Oct 8, 2024
dad4b21
Refactor nullable usage
IliaBrahinets Oct 8, 2024
e78a572
Fix nullable usage
IliaBrahinets Oct 8, 2024
ca6dbd8
Fix nullable usage
IliaBrahinets Oct 8, 2024
7c519af
Fix formatting
IliaBrahinets Oct 8, 2024
7eb42da
Merge branch 'main' into nullable-exporter-geneva
Kielek Oct 16, 2024
cf25f8a
additional cleanup
Kielek Oct 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/OpenTelemetry.Exporter.Geneva/EventNameExportMode.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
// Copyright The OpenTelemetry Authors
// SPDX-License-Identifier: Apache-2.0

#nullable enable

namespace OpenTelemetry.Exporter.Geneva;

/// <summary>
Expand Down
2 changes: 0 additions & 2 deletions src/OpenTelemetry.Exporter.Geneva/ExceptionStackExportMode.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
// Copyright The OpenTelemetry Authors
// SPDX-License-Identifier: Apache-2.0

#nullable enable

namespace OpenTelemetry.Exporter.Geneva;

/// <summary>
Expand Down
1 change: 0 additions & 1 deletion src/OpenTelemetry.Exporter.Geneva/External/TraceLoggingDynamic.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,6 @@ Most ETW decoding tools are unable to decode an event with more than 128
fields.
*/

#nullable enable

namespace OpenTelemetry.Exporter.Geneva.External;

Expand Down
2 changes: 0 additions & 2 deletions src/OpenTelemetry.Exporter.Geneva/GenevaBaseExporter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
// Copyright The OpenTelemetry Authors
// SPDX-License-Identifier: Apache-2.0

#nullable enable

namespace OpenTelemetry.Exporter.Geneva;

/// <summary>
Expand Down
2 changes: 0 additions & 2 deletions src/OpenTelemetry.Exporter.Geneva/GenevaExporterHelperExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
// Copyright The OpenTelemetry Authors
// SPDX-License-Identifier: Apache-2.0

#nullable enable

using System.Diagnostics;
using Microsoft.Extensions.DependencyInjection;
using Microsoft.Extensions.Options;
Expand Down
2 changes: 0 additions & 2 deletions src/OpenTelemetry.Exporter.Geneva/GenevaExporterOptions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
// Copyright The OpenTelemetry Authors
// SPDX-License-Identifier: Apache-2.0

#nullable enable

using System.Text;
using OpenTelemetry.Internal;

Expand Down
2 changes: 0 additions & 2 deletions src/OpenTelemetry.Exporter.Geneva/GenevaLogExporter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
// Copyright The OpenTelemetry Authors
// SPDX-License-Identifier: Apache-2.0

#nullable enable

using System.Runtime.InteropServices;
using OpenTelemetry.Exporter.Geneva.MsgPack;
using OpenTelemetry.Exporter.Geneva.Tld;
Expand Down
2 changes: 0 additions & 2 deletions src/OpenTelemetry.Exporter.Geneva/GenevaLoggingExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
// Copyright The OpenTelemetry Authors
// SPDX-License-Identifier: Apache-2.0

#nullable enable

using System.Diagnostics;
using Microsoft.Extensions.DependencyInjection;
using Microsoft.Extensions.Options;
Expand Down
2 changes: 0 additions & 2 deletions src/OpenTelemetry.Exporter.Geneva/GenevaTraceExporter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
// Copyright The OpenTelemetry Authors
// SPDX-License-Identifier: Apache-2.0

#nullable enable

using System.Diagnostics;
using System.Runtime.InteropServices;
using OpenTelemetry.Exporter.Geneva.MsgPack;
Expand Down
2 changes: 0 additions & 2 deletions src/OpenTelemetry.Exporter.Geneva/Internal/ConnectionStringBuilder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
// Copyright The OpenTelemetry Authors
// SPDX-License-Identifier: Apache-2.0

#nullable enable

using System.Diagnostics.CodeAnalysis;
using System.Globalization;
using OpenTelemetry.Exporter.Geneva.Transports;
Expand Down
2 changes: 0 additions & 2 deletions src/OpenTelemetry.Exporter.Geneva/Internal/ExporterEventSource.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
// Copyright The OpenTelemetry Authors
// SPDX-License-Identifier: Apache-2.0

#nullable enable

using System.Diagnostics.Tracing;
using OpenTelemetry.Internal;

Expand Down
2 changes: 0 additions & 2 deletions src/OpenTelemetry.Exporter.Geneva/Internal/MsgPack/MessagePackSerializer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
// Copyright The OpenTelemetry Authors
// SPDX-License-Identifier: Apache-2.0

#nullable enable

#if NET
using System.Buffers.Binary;
#endif
Expand Down
2 changes: 0 additions & 2 deletions src/OpenTelemetry.Exporter.Geneva/Internal/MsgPack/MsgPackExporter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
// Copyright The OpenTelemetry Authors
// SPDX-License-Identifier: Apache-2.0

#nullable enable

#if NET
using System.Collections.Frozen;
#endif
Expand Down
3 changes: 0 additions & 3 deletions src/OpenTelemetry.Exporter.Geneva/Internal/MsgPack/MsgPackLogExporter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
// Copyright The OpenTelemetry Authors
// SPDX-License-Identifier: Apache-2.0

#nullable enable

#if NET
using System.Collections.Frozen;
#endif
Expand Down Expand Up @@ -175,7 +173,6 @@ internal ArraySegment<byte> SerializeLogRecord(LogRecord logRecord)
// `LogRecord.State` and `LogRecord.StateValues` were marked Obsolete in https://github.com/open-telemetry/opentelemetry-dotnet/pull/4334
#pragma warning disable 0618
IReadOnlyList<KeyValuePair<string, object?>>? listKvp;

if (logRecord.StateValues != null)
{
listKvp = logRecord.StateValues;
Expand Down
2 changes: 0 additions & 2 deletions src/OpenTelemetry.Exporter.Geneva/Internal/MsgPack/MsgPackTraceExporter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
// Copyright The OpenTelemetry Authors
// SPDX-License-Identifier: Apache-2.0

#nullable enable

#if NET
using System.Collections.Frozen;
#endif
Expand Down
2 changes: 0 additions & 2 deletions src/OpenTelemetry.Exporter.Geneva/Internal/ReentrantActivityExportProcessor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
// Copyright The OpenTelemetry Authors
// SPDX-License-Identifier: Apache-2.0

#nullable enable

using System.Diagnostics;

namespace OpenTelemetry.Exporter.Geneva;
Expand Down
2 changes: 0 additions & 2 deletions src/OpenTelemetry.Exporter.Geneva/Internal/ReentrantExportProcessor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
// Copyright The OpenTelemetry Authors
// SPDX-License-Identifier: Apache-2.0

#nullable enable

using System.Linq.Expressions;
using System.Reflection;

Expand Down
2 changes: 0 additions & 2 deletions src/OpenTelemetry.Exporter.Geneva/Internal/Schema.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
// Copyright The OpenTelemetry Authors
// SPDX-License-Identifier: Apache-2.0

#nullable enable

namespace OpenTelemetry.Exporter.Geneva;

internal static class Schema
Expand Down
2 changes: 0 additions & 2 deletions src/OpenTelemetry.Exporter.Geneva/Internal/TableNameSerializer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
// Copyright The OpenTelemetry Authors
// SPDX-License-Identifier: Apache-2.0

#nullable enable

using System.Diagnostics;
using System.Runtime.CompilerServices;
using System.Text;
Expand Down
2 changes: 0 additions & 2 deletions src/OpenTelemetry.Exporter.Geneva/Internal/Tld/JsonSerializer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
// Copyright The OpenTelemetry Authors
// SPDX-License-Identifier: Apache-2.0

#nullable enable

using System.Globalization;
using System.Runtime.CompilerServices;
using System.Text;
Expand Down
2 changes: 0 additions & 2 deletions src/OpenTelemetry.Exporter.Geneva/Internal/Tld/TldExporter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
// Copyright The OpenTelemetry Authors
// SPDX-License-Identifier: Apache-2.0

#nullable enable

using System.Diagnostics;
using System.Globalization;
using System.Runtime.CompilerServices;
Expand Down
2 changes: 0 additions & 2 deletions src/OpenTelemetry.Exporter.Geneva/Internal/Tld/TldLogExporter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
// Copyright The OpenTelemetry Authors
// SPDX-License-Identifier: Apache-2.0

#nullable enable

using System.Diagnostics;
using System.Globalization;
using System.Runtime.CompilerServices;
Expand Down
2 changes: 0 additions & 2 deletions src/OpenTelemetry.Exporter.Geneva/Internal/Tld/TldTraceExporter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
// Copyright The OpenTelemetry Authors
// SPDX-License-Identifier: Apache-2.0

#nullable enable

using System.Diagnostics;
using System.Globalization;
using System.Text;
Expand Down
2 changes: 0 additions & 2 deletions src/OpenTelemetry.Exporter.Geneva/Internal/Tld/UncheckedASCIIEncoding.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
// Copyright The OpenTelemetry Authors
// SPDX-License-Identifier: Apache-2.0

#nullable enable

using System.Text;
using OpenTelemetry.Internal;

Expand Down
2 changes: 0 additions & 2 deletions src/OpenTelemetry.Exporter.Geneva/Internal/Transports/EtwDataTransport.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
// Copyright The OpenTelemetry Authors
// SPDX-License-Identifier: Apache-2.0

#nullable enable

#if NET
using System.Diagnostics.CodeAnalysis;
#endif
Expand Down
2 changes: 0 additions & 2 deletions src/OpenTelemetry.Exporter.Geneva/Internal/Transports/IDataTransport.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
// Copyright The OpenTelemetry Authors
// SPDX-License-Identifier: Apache-2.0

#nullable enable

namespace OpenTelemetry.Exporter.Geneva.Transports;

internal interface IDataTransport
Expand Down
2 changes: 0 additions & 2 deletions src/OpenTelemetry.Exporter.Geneva/Internal/Transports/UnixDomainSocketDataTransport.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
// Copyright The OpenTelemetry Authors
// SPDX-License-Identifier: Apache-2.0

#nullable enable

using System.Diagnostics.CodeAnalysis;
using System.Net;
using System.Net.Sockets;
Expand Down
2 changes: 0 additions & 2 deletions src/OpenTelemetry.Exporter.Geneva/Internal/Transports/UnixDomainSocketEndPoint.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@

#if !NET

#nullable enable

using System.Text;
using OpenTelemetry.Internal;

Expand Down
2 changes: 0 additions & 2 deletions src/OpenTelemetry.Exporter.Geneva/Metrics/GenevaMetricExporter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
// Copyright The OpenTelemetry Authors
// SPDX-License-Identifier: Apache-2.0

#nullable enable

using System.Reflection;
using System.Text.RegularExpressions;
using OpenTelemetry.Exporter.Geneva.Metrics;
Expand Down
2 changes: 0 additions & 2 deletions src/OpenTelemetry.Exporter.Geneva/Metrics/GenevaMetricExporterExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
// Copyright The OpenTelemetry Authors
// SPDX-License-Identifier: Apache-2.0

#nullable enable

using Microsoft.Extensions.DependencyInjection;
using Microsoft.Extensions.Options;
using OpenTelemetry.Internal;
Expand Down
2 changes: 0 additions & 2 deletions src/OpenTelemetry.Exporter.Geneva/Metrics/GenevaMetricExporterOptions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
// Copyright The OpenTelemetry Authors
// SPDX-License-Identifier: Apache-2.0

#nullable enable

using System.Globalization;
using OpenTelemetry.Internal;

Expand Down
2 changes: 0 additions & 2 deletions src/OpenTelemetry.Exporter.Geneva/Metrics/MetricSerializer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
// Copyright The OpenTelemetry Authors
// SPDX-License-Identifier: Apache-2.0

#nullable enable

using System.Runtime.CompilerServices;
using System.Runtime.InteropServices;
using System.Text;
Expand Down
2 changes: 0 additions & 2 deletions src/OpenTelemetry.Exporter.Geneva/Metrics/OtlpProtobuf/FieldNumberConstants.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
// Copyright The OpenTelemetry Authors
// SPDX-License-Identifier: Apache-2.0

#nullable enable

using System.Runtime.CompilerServices;
using OpenTelemetry.Metrics;

Expand Down
2 changes: 0 additions & 2 deletions src/OpenTelemetry.Exporter.Geneva/Metrics/OtlpProtobuf/OtlpProtobufMetricExporter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
// Copyright The OpenTelemetry Authors
// SPDX-License-Identifier: Apache-2.0

#nullable enable

using System.Diagnostics;
using System.Runtime.InteropServices;
using OpenTelemetry.Metrics;
Expand Down
2 changes: 0 additions & 2 deletions src/OpenTelemetry.Exporter.Geneva/Metrics/OtlpProtobuf/OtlpProtobufSerializer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
// Copyright The OpenTelemetry Authors
// SPDX-License-Identifier: Apache-2.0

#nullable enable

using System.Diagnostics;
using System.Globalization;
using OpenTelemetry.Metrics;
Expand Down
2 changes: 0 additions & 2 deletions src/OpenTelemetry.Exporter.Geneva/Metrics/OtlpProtobuf/ProtobufSerializerHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
// Copyright The OpenTelemetry Authors
// SPDX-License-Identifier: Apache-2.0

#nullable enable

using System.Buffers.Binary;
using System.Runtime.CompilerServices;
using System.Text;
Expand Down
2 changes: 0 additions & 2 deletions src/OpenTelemetry.Exporter.Geneva/Metrics/OtlpProtobuf/TimestampHelpers.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
// Copyright The OpenTelemetry Authors
// SPDX-License-Identifier: Apache-2.0

#nullable enable

namespace OpenTelemetry.Exporter.Geneva;

/// <summary>
Expand Down
2 changes: 0 additions & 2 deletions src/OpenTelemetry.Exporter.Geneva/Metrics/OtlpProtobuf/WireType.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
// Copyright The OpenTelemetry Authors
// SPDX-License-Identifier: Apache-2.0

#nullable enable

namespace OpenTelemetry.Exporter.Geneva;

/// <summary>
Expand Down
2 changes: 0 additions & 2 deletions src/OpenTelemetry.Exporter.Geneva/Metrics/TlvMetricExporter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
// Copyright The OpenTelemetry Authors
// SPDX-License-Identifier: Apache-2.0

#nullable enable

using System.Globalization;
using System.Runtime.CompilerServices;
using System.Runtime.InteropServices;
Expand Down
2 changes: 0 additions & 2 deletions src/OpenTelemetry.Exporter.Geneva/Metrics/Transport/IMetricDataTransport.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
// Copyright The OpenTelemetry Authors
// SPDX-License-Identifier: Apache-2.0

#nullable enable

namespace OpenTelemetry.Exporter.Geneva;

internal interface IMetricDataTransport : IDisposable
Expand Down
2 changes: 0 additions & 2 deletions src/OpenTelemetry.Exporter.Geneva/Metrics/Transport/MetricUnixDomainSocketDataTransport.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
// Copyright The OpenTelemetry Authors
// SPDX-License-Identifier: Apache-2.0

#nullable enable

using OpenTelemetry.Exporter.Geneva.Transports;

namespace OpenTelemetry.Exporter.Geneva;
Expand Down
2 changes: 0 additions & 2 deletions src/OpenTelemetry.Exporter.Geneva/Metrics/Transport/MetricUnixUserEventsDataTransport.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@

#if NET

#nullable enable

using System.Text;
using Microsoft.LinuxTracepoints.Provider;

Expand Down
2 changes: 0 additions & 2 deletions ...OpenTelemetry.Exporter.Geneva/Metrics/Transport/MetricWindowsEventTracingDataTransport.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
// Copyright The OpenTelemetry Authors
// SPDX-License-Identifier: Apache-2.0

#nullable enable

#if NET
using System.Diagnostics.CodeAnalysis;
#endif
Expand Down
Loading
Loading