[Exporter.Geneva] Enable nullable globally #2190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/OpenTelemetry.Exporter.Geneva/.publicApi/PublicAPI.Shipped.txt # src/OpenTelemetry.Exporter.Geneva/GenevaExporterHelperExtensions.cs # src/OpenTelemetry.Exporter.Geneva/GenevaExporterOptions.cs # src/OpenTelemetry.Exporter.Geneva/GenevaLoggingExtensions.cs # src/OpenTelemetry.Exporter.Geneva/Internal/ConnectionStringBuilder.cs # src/OpenTelemetry.Exporter.Geneva/Internal/MsgPack/MsgPackExporter.cs # src/OpenTelemetry.Exporter.Geneva/Internal/MsgPack/MsgPackLogExporter.cs # src/OpenTelemetry.Exporter.Geneva/Internal/MsgPack/MsgPackTraceExporter.cs # src/OpenTelemetry.Exporter.Geneva/Internal/ReentrantExportProcessor.cs # src/OpenTelemetry.Exporter.Geneva/Internal/TableNameSerializer.cs # src/OpenTelemetry.Exporter.Geneva/Internal/Tld/JsonSerializer.cs # src/OpenTelemetry.Exporter.Geneva/Internal/Tld/TldExporter.cs # src/OpenTelemetry.Exporter.Geneva/Internal/Tld/TldLogExporter.cs # src/OpenTelemetry.Exporter.Geneva/Internal/Tld/TldTraceExporter.cs # src/OpenTelemetry.Exporter.Geneva/Internal/Transports/UnixDomainSocketDataTransport.cs # src/OpenTelemetry.Exporter.Geneva/Metrics/GenevaMetricExporter.cs # src/OpenTelemetry.Exporter.Geneva/Metrics/GenevaMetricExporterExtensions.cs # src/OpenTelemetry.Exporter.Geneva/Metrics/GenevaMetricExporterOptions.cs # src/OpenTelemetry.Exporter.Geneva/Metrics/OtlpProtobuf/OtlpProtobufSerializer.cs # src/OpenTelemetry.Exporter.Geneva/Metrics/TlvMetricExporter.cs # src/Shared/NullableAttributes.cs
IliaBrahinets
had a problem deploying
to
external
GitHub Actions
Failure
github-actions
bot
assigned cijothomas, CodeBlanch, rajkumar-rangaraj, reyang and utpilla
github-actions
bot
requested review from
cijothomas,
CodeBlanch,
rajkumar-rangaraj,
reyang and
utpilla
github-actions
bot
added
the
comp:exporter.geneva
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2190 +/- ##
==========================================
- Coverage 73.91% 71.05% -2.86%
==========================================
Files 267 333 +66
Lines 9615 13001 +3386
==========================================
+ Hits 7107 9238 +2131
- Misses 2508 3763 +1255
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
@IliaBrahinets Thanks for this! I don't have the cycles at the moment to review everything. Also trying to get #2113 done in the same area. I'll get to this as soon as I can! Might break it up into smaller chunks. |
Kielek
force-pushed
the
nullable-exporter-geneva
branch
from
63cfba9 to
cf25f8a
Compare
Kielek
approved these changes
Oct 16, 2024
There was a problem hiding this comment.
LGTM.
@CodeBlanch, merging as it contains only removals of #nullable enable + csproj tweak.
Only leftovers we have stays in Geneva Tests projects.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #894
Changes
Enable nullable globally in
OpenTelemtry.Exporter.Geneva. Tests will be covered in another PR to avoid huge one.Merge requirement checklist
Unit tests added/updatedAppropriateCHANGELOG.mdfiles updated for non-trivial changes