Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[repo] Core version update improvements #1882

Conversation

CodeBlanch
Copy link
Member

Changes

  • Adds support for updating OpenTelemetryCoreUnstableLatestVersion (introduced in [repo] Separate pkg version for core-unstable packages #1870) when a coreunstable- tag is released from main repo.
  • Switches to \n instead of \r\n for line-endings to make sanity check happy and reduce changes shown on CHANGELOG diffs.

Details

Test runs:

@CodeBlanch CodeBlanch requested a review from a team June 12, 2024 17:20
@github-actions github-actions bot added the infra Infra work - CI/CD, code coverage, linters label Jun 12, 2024
Copy link

codecov bot commented Jun 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.60%. Comparing base (71655ce) to head (66fce54).
Report is 303 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1882      +/-   ##
==========================================
- Coverage   73.91%   73.60%   -0.32%     
==========================================
  Files         267      278      +11     
  Lines        9615    10523     +908     
==========================================
+ Hits         7107     7745     +638     
- Misses       2508     2778     +270     
Flag Coverage Δ
unittests-Exporter.Geneva 64.81% <ø> (?)
unittests-Exporter.InfluxDB 95.88% <ø> (?)
unittests-Exporter.Instana 68.22% <ø> (?)
unittests-Exporter.OneCollector 91.29% <ø> (?)
unittests-Exporter.Stackdriver 75.73% <ø> (?)
unittests-Extensions 79.33% <ø> (?)
unittests-Extensions.AWS 83.41% <ø> (?)
unittests-Extensions.Enrichment 100.00% <ø> (?)
unittests-Instrumentation.AWS 80.59% <ø> (?)
unittests-Instrumentation.AWSLambda 87.96% <ø> (?)
unittests-Instrumentation.AspNet 74.85% <ø> (?)
unittests-Instrumentation.AspNetCore 85.27% <ø> (?)
unittests-Instrumentation.ElasticsearchClient 79.87% <ø> (?)
unittests-Instrumentation.EntityFrameworkCore 55.49% <ø> (?)
unittests-Instrumentation.EventCounters 76.36% <ø> (?)
unittests-Instrumentation.GrpcNetClient 79.61% <ø> (?)
unittests-Instrumentation.Hangfire 93.58% <ø> (?)
unittests-Instrumentation.Http 81.08% <ø> (?)
unittests-Instrumentation.Process 100.00% <ø> (?)
unittests-Instrumentation.Quartz 78.94% <ø> (?)
unittests-Instrumentation.Runtime 100.00% <ø> (?)
unittests-Instrumentation.SqlClient 90.90% <ø> (?)
unittests-Instrumentation.StackExchangeRedis 68.02% <ø> (?)
unittests-Instrumentation.Wcf 48.91% <ø> (?)
unittests-PersistentStorage 65.44% <ø> (?)
unittests-Resources.AWS 74.53% <ø> (?)
unittests-Resources.Azure 78.35% <ø> (?)
unittests-Resources.Container 72.41% <ø> (?)
unittests-Resources.Gcp 72.54% <ø> (?)
unittests-Resources.Host 47.67% <ø> (?)
unittests-Resources.Process 81.81% <ø> (?)
unittests-Resources.ProcessRuntime 82.35% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 303 files with indirect coverage changes

@CodeBlanch CodeBlanch merged commit 1913cd0 into open-telemetry:main Jun 13, 2024
266 of 267 checks passed
@CodeBlanch CodeBlanch deleted the repo-core-version-update-improvements branch June 13, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infra Infra work - CI/CD, code coverage, linters
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants