-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[repo] Separate pkg version for core-unstable packages #1870
Merged
CodeBlanch
merged 2 commits into
open-telemetry:main
from
vishweshbankwar:vibankwa/fix-prometheus-version
Jun 8, 2024
Merged
[repo] Separate pkg version for core-unstable packages #1870
CodeBlanch
merged 2 commits into
open-telemetry:main
from
vishweshbankwar:vibankwa/fix-prometheus-version
Jun 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vishweshbankwar
had a problem deploying
to
external
June 7, 2024 23:12 — with
GitHub Actions
Failure
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1870 +/- ##
==========================================
- Coverage 73.91% 70.16% -3.75%
==========================================
Files 267 296 +29
Lines 9615 10821 +1206
==========================================
+ Hits 7107 7593 +486
- Misses 2508 3228 +720 Flags with carried forward coverage won't be shown. Click here to find out more. |
vishweshbankwar
had a problem deploying
to
external
June 7, 2024 23:16 — with
GitHub Actions
Failure
vishweshbankwar
changed the title
Separate pkg version for non-core packages
Separate pkg version for core-unstable packages
Jun 7, 2024
CodeBlanch
changed the title
Separate pkg version for core-unstable packages
[repo] Separate pkg version for core-unstable packages
Jun 8, 2024
CodeBlanch
approved these changes
Jun 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the build failures from #1869
Changes
Please provide a brief description of the changes here.
For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes