-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement message queue #457
Implement message queue #457
Conversation
Hey just an fyi we're on a feature freeze for the next week or 2 due to our upcoming v1 release and kubecon. Feel free to keep this open and working on it tho! |
# Conflicts: # README.md # docker-compose.yml
I wonder that why add two new services? Since the checkout service is the only kafka message producer, the two new services are both consumers. What's the point of this? |
Async workflows usually have multiple consumers with different use cases. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
we should test the build time increase from 3 new containers. One thing to keep in mind is that go doesn’t have an operator instrumentation option. We’d need to implement that with the Java service or replace Go |
For the architecture docs and services table my bias would be to label the language Java not Kotlin for the fraud detection service |
I have tested builds again this branch and main. Setup:
Methodology implemented changes:
main ( 5a2c0ef ):
So there are no relevant changes. The limiting factor is the build time of the
I prefer to use Kotlin as this signals that multiple JVM languages are supported. An alternative would be to rename JAVA to JVM |
From the Google docs:
@julianocosta89 @cartersocha @puckpuck I have not been able to join the SIG Meeting, is there a decision to rewrite |
The goal is to get this PR merged this week with Go for the After the merge, we will rewrite the service in another language that can be auto-instrumented with the OpenTelemetry Operator. We may want to document that as part of this PR so expectations are set with the broader community. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. Ready to merge after @julianocosta89 or @puckpuck get a chance to take a look.
Thank you @secustor for the big addition!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for this. Docs are great too. I do have some non-functional items that I would like addressed, but everything else looks ready to go.
src/frauddetectionservice/src/main/kotlin/frauddetectionservice/main.kt
Outdated
Show resolved
Hide resolved
Signed-off-by: Pierre Tessier <[email protected]>
Signed-off-by: Pierre Tessier <[email protected]>
Signed-off-by: Pierre Tessier <[email protected]>
Signed-off-by: Pierre Tessier <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made some changes to logging as well as added health checks.
I also changed the name of the kafka container to: kafka
🎉 |
Fixes #429
Changes
checkoutservice
For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes