-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #586: Pass categories
as an input for Ad service
#600
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@madhead please make a changelog entry and I'll merge 🚀 |
@cartersocha, done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@puckpuck not all of the requests: |
I also tested this and most of the time |
@mviitane , @julianocosta89, @puckpuck I agree, I saw those empty requests too, but didn't address them here. I'm not an React expert, but the bigger problem here, IMO, is that Looking at three usages of this provider:
In some of this contexts the categories are inherently empty. I would say, this should be fixed and split into two different provider components. But, I could just "short-circuit" this call, what do you think? Like adding a check, a guard clause, "if the categories are empty, then just return an empty list of adds". Or something similar to remove this unneeded call. A dirty hack, but it should work. Would it be ok? |
…he Ad service
I totally forgot about the load generator. It might be sending incorrect requests too. I've added both fixes, please check the PR now (beware of the cached images!). |
@austinlparker we should test the build time increase from 3 new containers. One thing to keep in mind is that go doesn’t have an operator instrumentation option. We’d need to implement that with the Java service or replace Go |
For the architecture docs and services table my bias would be to label the language Java not Kotlin for the fraud detection service |
@cartersocha I think your comments are regarding #457, and not this one😅 |
Lol the perils of mobile bulk reviews @julianocosta89. Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After the update we always get a context.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed this provides proper context keys on all requests types.
…he Ad service (open-telemetry#600) Co-authored-by: Juliano Costa <[email protected]> Co-authored-by: Pierre Tessier <[email protected]>
Fixes #586.
Changes
categories
as an input for Ad serviceSet
. I hope this is OK for a demo.