Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(receiver/otlpreceiver): make the configuration HttpServerSettings public #8176

Conversation

lpegoraro
Copy link
Contributor

Description: Make the configuration for the OTLP Receiver httpServerSettings to be public
Fixing the bug opened #8175

Link to tracking Issue:#8175

@lpegoraro lpegoraro requested review from a team and Aneurysm9 August 3, 2023 20:29
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Aug 3, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

mx-psi
mx-psi previously approved these changes Aug 4, 2023
Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This was added in #7570, I see no discussion there on this being made private for any specific reason, and our policy today is to have all configuration as part of the public API

@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01% 🎉

Comparison is base (611a589) 90.25% compared to head (61cf7ac) 90.27%.
Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8176      +/-   ##
==========================================
+ Coverage   90.25%   90.27%   +0.01%     
==========================================
  Files         301      301              
  Lines       15551    15581      +30     
==========================================
+ Hits        14035    14065      +30     
  Misses       1227     1227              
  Partials      289      289              
Files Changed Coverage Δ
receiver/otlpreceiver/config.go 97.36% <ø> (ø)
receiver/otlpreceiver/factory.go 76.56% <100.00%> (ø)

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mx-psi
Copy link
Member

mx-psi commented Aug 4, 2023

@lpegoraro can you add a changelog entry?

Copy link
Member

@jpkrohling jpkrohling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @lpegoraro, can you please add an entry to the changelog, by adding a new file to .chloggen?

@lpegoraro
Copy link
Contributor Author

hey, just added. not sure if it is by standards, let me know if anything.

@lpegoraro
Copy link
Contributor Author

Do we need anything else?
I cannot merge.

@mx-psi mx-psi dismissed their stale review August 9, 2023 10:06

Let's rename the struct first, since we have the chance to do it now comfortably

@lpegoraro
Copy link
Contributor Author

any news on this?

@mx-psi
Copy link
Member

mx-psi commented Aug 14, 2023

Can you merge/rebase main, so the tests pass?

@dmitryax dmitryax merged commit 56ed343 into open-telemetry:main Aug 15, 2023
@codeboten codeboten modified the milestones: v0.83.0, next release Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants