Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OTLPReceiver is with config private, it needs to be public for create from other packages #8175

Closed
lpegoraro opened this issue Aug 3, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@lpegoraro
Copy link
Contributor

Describe the bug
The httpServerSettings from otlpreceiver.config.go needs to be public,

Steps to reproduce
NA

What did you expect to see?

type HttpServerSettings struct {
   *confighttp.HTTPServerSettings `mapstructure:",squash"`

   // The URL path to receive traces on. If omitted "/v1/traces" will be used.
   TracesURLPath string `mapstructure:"traces_url_path,omitempty"`

   // The URL path to receive metrics on. If omitted "/v1/metrics" will be used.
   MetricsURLPath string `mapstructure:"metrics_url_path,omitempty"`

   // The URL path to receive logs on. If omitted "/v1/logs" will be used.
   LogsURLPath string `mapstructure:"logs_url_path,omitempty"`
}

What did you see instead?

type httpServerSettings struct {
   *confighttp.HTTPServerSettings `mapstructure:",squash"`

   // The URL path to receive traces on. If omitted "/v1/traces" will be used.
   TracesURLPath string `mapstructure:"traces_url_path,omitempty"`

   // The URL path to receive metrics on. If omitted "/v1/metrics" will be used.
   MetricsURLPath string `mapstructure:"metrics_url_path,omitempty"`

   // The URL path to receive logs on. If omitted "/v1/logs" will be used.
   LogsURLPath string `mapstructure:"logs_url_path,omitempty"`
}

What version did you use?
0.82.0

What config did you use?
N/A

Environment
N/A

Additional context
No additional context

@lpegoraro lpegoraro added the bug Something isn't working label Aug 3, 2023
dmitryax added a commit that referenced this issue Aug 15, 2023
**Description:** Make the configuration for the OTLP Receiver
httpServerSettings to be public
Fixing the bug opened  #8175 

**Link to tracking Issue:**#8175

---------

Co-authored-by: Pablo Baeyens <[email protected]>
Co-authored-by: Dmitrii Anoshin <[email protected]>
@atoulme atoulme closed this as completed Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants