Cleanup E2E tests #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduce TestCase.WaitFor function that waits until specified condition becomes true. - Make performance tests faster and reliable by waiting for spans to be received using WaitFor instead of fixed time period. - Introduce TestCase.Sleep function to reduce boilerplate in test cases.
tigrannajaryan
requested review from
bogdandrutu,
flands,
pjanotti and
songy23
as code owners
Closed
songy23
approved these changes
Jul 1, 2019
owais
approved these changes
Jul 1, 2019
pjanotti
approved these changes
Jul 1, 2019
| @@ -70,7 +70,7 @@ func WaitFor(t *testing.T, cond func() bool, errMsg ...interface{}) bool { | |||
| return true | |||
| } | |||
|
|
|||
| if time.Since(startTime) > time.Second*5 { | |||
| if time.Since(startTime) > time.Second*10 { | |||
There was a problem hiding this comment.
this feels like it should be a parameter but it can wait until a real case usage of different values
There was a problem hiding this comment.
Sure, we can add it if needed. My past experience has been that it is needed very rarely and it is easier to make it a global settings to avoid specifying it for every waitfor.
hughesjj
pushed a commit
to hughesjj/opentelemetry-collector
that referenced
this pull request
Apr 27, 2023
…emetry#79) * smart agent: break out reflection helpers * smart agent: Adopt Endpoint field for receivercreator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
becomes true.
using WaitFor instead of fixed time period.