-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pdata] Rename pmetric.MetricDataPointFlags to pmetric.DataPointFlags #6259
[pdata] Rename pmetric.MetricDataPointFlags to pmetric.DataPointFlags #6259
Conversation
Codecov ReportBase: 92.30% // Head: 92.22% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #6259 +/- ##
==========================================
- Coverage 92.30% 92.22% -0.08%
==========================================
Files 219 219
Lines 13463 13466 +3
==========================================
- Hits 12427 12419 -8
- Misses 806 817 +11
Partials 230 230
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
where is the DataPointFlags defined? |
Read the description. Base on what rule do you think this change should be done? |
Right, the description is a bit incorrect. This is proto enum not a message https://github.com/open-telemetry/opentelemetry-proto/blob/main/opentelemetry/proto/metrics/v1/metrics.proto#L321. But I believe we should apply the same rule for enums. Do you think otherwise? |
Updated the description |
Following pdata naming rules outlined in #6255, we want to update the struct to have the same name as defined in protobuf package.
Updates #6257