Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pdata] Rename ptrace.SpanStatus to ptrace.Status #6258

Merged
merged 2 commits into from
Oct 10, 2022
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@
- Deprecate `pcommon.NewValueString` in favor of `pcommon.NewValueStr` (#6209)
- Deprecate `pmetric.MetricAggregationTemporality` enum type in favor of `pmetric.AggregationTemporality` (#6249)
- Deprecate `confmap.Conf.UnmarshalExact` in favor of `confmap.Conf.Unmarshal(.., WithErrorUnused)` (#6231)
- Deprecate `ptrace.SpanStatus` favor of `ptrace.Status` (#6258)

### 💡 Enhancements 💡

Expand Down
4 changes: 2 additions & 2 deletions pdata/internal/cmd/pdatagen/internal/trace_structs.go
Original file line number Diff line number Diff line change
Expand Up @@ -188,8 +188,8 @@ var spanLink = &messageValueStruct{
}

var spanStatus = &messageValueStruct{
structName: "SpanStatus",
description: "// SpanStatus is an optional final status for this span. Semantically, when Status was not\n" +
structName: "Status",
description: "// Status is an optional final status for this span. Semantically, when Status was not\n" +
"// set, that means the span ended without errors and to assume Status.Ok (code = 0).",
originFullName: "otlptrace.Status",
fields: []baseField{
Expand Down
18 changes: 9 additions & 9 deletions pdata/internal/generated_wrapper_traces.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

44 changes: 22 additions & 22 deletions pdata/ptrace/generated_traces.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

30 changes: 15 additions & 15 deletions pdata/ptrace/generated_traces_test.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions pdata/ptrace/traces.go
Original file line number Diff line number Diff line change
Expand Up @@ -110,3 +110,9 @@ const (

// String returns the string representation of the StatusCode.
func (sc StatusCode) String() string { return otlptrace.Status_StatusCode(sc).String() }

// Deprecated: [0.62.0] Use Status instead.
type SpanStatus = Status

// Deprecated: [0.62.0] Use NewStatus instead.
var NewSpanStatus = NewStatus