Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pdata] Rename ptrace.SpanStatus to ptrace.Status #6258

Merged
merged 2 commits into from
Oct 10, 2022

Conversation

dmitryax
Copy link
Member

@dmitryax dmitryax commented Oct 8, 2022

As a new rule we want to rename all the structs for proto messages defined at the package level to not have the owner prefix in its name. Protobuf for message for trace.Status is defined at the top level https://github.com/open-telemetry/opentelemetry-proto/blob/main/opentelemetry/proto/trace/v1/trace.proto#L260. It also brings consistency with existing trace.StatusCode type.

Updates #6257

@dmitryax dmitryax changed the title [pdata] Rename ptrace.SpanStatus to trace.Status [pdata] Rename ptrace.SpanStatus to ptrace.Status Oct 8, 2022
@dmitryax dmitryax marked this pull request as ready for review October 8, 2022 00:40
@dmitryax dmitryax requested review from a team and tigrannajaryan October 8, 2022 00:40
@codecov
Copy link

codecov bot commented Oct 8, 2022

Codecov Report

Base: 92.30% // Head: 92.30% // No change to project coverage 👍

Coverage data is based on head (040bd7a) compared to base (8a346b0).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6258   +/-   ##
=======================================
  Coverage   92.30%   92.30%           
=======================================
  Files         219      219           
  Lines       13455    13455           
=======================================
  Hits        12419    12419           
  Misses        806      806           
  Partials      230      230           
Impacted Files Coverage Δ
pdata/ptrace/traces.go 92.00% <ø> (ø)
pdata/internal/generated_wrapper_traces.go 100.00% <100.00%> (ø)
pdata/ptrace/generated_traces.go 97.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bogdandrutu bogdandrutu merged commit a3f96ff into open-telemetry:main Oct 10, 2022
@dmitryax dmitryax deleted the rename-SpanStatus branch October 11, 2022 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants