Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pdata] Rename MetricAggregationTemporality to AggregationTemporality #6253

Conversation

dmitryax
Copy link
Member

@dmitryax dmitryax commented Oct 7, 2022

As a new rule we want to rename all the structs for proto messages defined at the package level to not have the owner prefix in its name.

Updates #6257

As a new rule we want to rename all the structs for proto messages defined at the package level to not have the owner prefix in its name.
@dmitryax dmitryax marked this pull request as ready for review October 7, 2022 16:02
@dmitryax dmitryax requested review from a team and codeboten October 7, 2022 16:02
@codecov
Copy link

codecov bot commented Oct 7, 2022

Codecov Report

Base: 92.22% // Head: 92.22% // No change to project coverage 👍

Coverage data is based on head (122db55) compared to base (05d1c5f).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6253   +/-   ##
=======================================
  Coverage   92.22%   92.22%           
=======================================
  Files         219      219           
  Lines       13446    13446           
=======================================
  Hits        12401    12401           
  Misses        815      815           
  Partials      230      230           
Impacted Files Coverage Δ
pdata/pmetric/generated_metrics.go 96.09% <100.00%> (ø)
pdata/pmetric/metrics.go 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants