Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pdata] Rename pcommon.Map.PutString to PutStr #6210

Merged
merged 2 commits into from
Oct 3, 2022

Conversation

dmitryax
Copy link
Member

Deprecate pcommon.Map.PutString in favor of pcommon.Map.PutStr for consistency with pcommon.ValueTypeStr and other related functions

@dmitryax dmitryax requested review from a team and mx-psi September 30, 2022 00:15
@codecov
Copy link

codecov bot commented Sep 30, 2022

Codecov Report

Base: 91.87% // Head: 91.86% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (25ce5e5) compared to base (6098109).
Patch coverage: 33.33% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6210      +/-   ##
==========================================
- Coverage   91.87%   91.86%   -0.02%     
==========================================
  Files         219      219              
  Lines       13533    13535       +2     
==========================================
  Hits        12434    12434              
- Misses        870      872       +2     
  Partials      229      229              
Impacted Files Coverage Δ
pdata/pcommon/common.go 89.56% <33.33%> (-0.36%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dmitryax dmitryax force-pushed the deprecate-put-string branch from 8650503 to d9cd793 Compare September 30, 2022 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants