Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pdata] Rename pcommon.NewValueString to pcommon.NewValueStr #6209

Merged
merged 1 commit into from
Sep 30, 2022

Conversation

dmitryax
Copy link
Member

@dmitryax dmitryax commented Sep 30, 2022

Resolves #6201

Deprecate pcommon.NewValueString in favor of pcommon.NewValueStr for consistency with pcommon.ValueTypeStr

@dmitryax dmitryax requested review from a team and bogdandrutu September 30, 2022 00:12
@dmitryax dmitryax force-pushed the deprecate-NewValueString branch from 6d53990 to 4c4163c Compare September 30, 2022 00:12
@codecov
Copy link

codecov bot commented Sep 30, 2022

Codecov Report

Base: 91.87% // Head: 91.87% // No change to project coverage 👍

Coverage data is based on head (a5bb33a) compared to base (e9311f6).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6209   +/-   ##
=======================================
  Coverage   91.87%   91.87%           
=======================================
  Files         219      219           
  Lines       13533    13533           
=======================================
  Hits        12434    12434           
  Misses        870      870           
  Partials      229      229           
Impacted Files Coverage Δ
pdata/pcommon/common.go 89.92% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dmitryax dmitryax force-pushed the deprecate-NewValueString branch from 4c4163c to a5bb33a Compare September 30, 2022 00:23
@bogdandrutu bogdandrutu merged commit 6098109 into open-telemetry:main Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should pcommon. NewValueString be NewValueStr?
3 participants