New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should pcommon. NewValueString be NewValueStr? #6201

Closed

bogdandrutu opened this issue Sep 29, 2022 · 1 comment · Fixed by #6209

Assignees

Labels

bug

Milestone

go.opentelemetry....

Member

bogdandrutu commented Sep 29, 2022

No description provided.

bogdandrutu added the bug label

bogdandrutu added this to the `go.opentelemetry.io/collector/model` 1.0 milestone

bogdandrutu assigned dmitryax

Member

dmitryax commented Sep 30, 2022

Nice catch. I believe it should be renamed for consistency

dmitryax mentioned this issue

[pdata] Rename pcommon.NewValueString to pcommon.NewValueStr #6209

Merged

bogdandrutu closed this as completed in #6209

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment