Remove unnecessary duplicate code and allocations for reading enums in JSON #5928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdandrutu
force-pushed
the
rmduplicateenums
branch
from
46c8596 to
2704198
Compare
Codecov Report
@@ Coverage Diff @@
## main #5928 +/- ##
==========================================
- Coverage 91.94% 91.93% -0.01%
==========================================
Files 199 200 +1
Lines 12409 12406 -3
==========================================
- Hits 11409 11406 -3
Misses 789 789
Partials 211 211
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Comment from the initial PR, #5924 (comment). Will not address since that will block adding new values to the enums. |
bogdandrutu
force-pushed
the
rmduplicateenums
branch
3 times, most recently
from
7112cec to
6ad3d2b
Compare
…n JSON Signed-off-by: Bogdan <[email protected]>
bogdandrutu
force-pushed
the
rmduplicateenums
branch
from
6ad3d2b to
acbd295
Compare
This was referenced Sep 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Bogdan [email protected]