-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix json trace/metrics unmarshaling for numbers #5924
Conversation
407107d
to
769a475
Compare
Codecov Report
@@ Coverage Diff @@
## main #5924 +/- ##
==========================================
+ Coverage 91.80% 91.84% +0.03%
==========================================
Files 198 198
Lines 12377 12429 +52
==========================================
+ Hits 11363 11415 +52
Misses 800 800
Partials 214 214
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
b4b1b48
to
c000949
Compare
Github shows lots of line changes but it seems many of the changes are just moving the code without changing functionality. Can you summarize the changes (other than performance improvement)? |
@tigrannajaryan good point, split the first simple PR #5926 then will split one more time to have focus changes. A set of the changes are in the CHANGELOG, one thing I don't like about having a CHANGELOG is that you will ask me to copy same thing in the contrib description :))) |
c000949
to
75200bb
Compare
696f5e2
to
67163d4
Compare
- Accept both string and number for int32/uint32. - Read uint64 numbers without converting from int64. Signed-off-by: Bogdan <[email protected]>
67163d4
to
61b0c60
Compare
Updates #5312
Also this improves benchmarks since
ReadAny
was doing an allocation, see:Before:
After: