Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate confmap.Received.AsMap in favor of confmap.Received.AsConf #5465

Merged
merged 1 commit into from
Jun 3, 2022

Conversation

bogdandrutu
Copy link
Member

Followup after #5237 when I forgot to change the name of this func accordingly to the new Conf name.

Signed-off-by: Bogdan Drutu [email protected]

@codecov
Copy link

codecov bot commented Jun 2, 2022

Codecov Report

Merging #5465 (80ad93a) into main (e0cf05e) will increase coverage by 0.01%.
The diff coverage is 60.00%.

@@            Coverage Diff             @@
##             main    #5465      +/-   ##
==========================================
+ Coverage   90.82%   90.84%   +0.01%     
==========================================
  Files         193      193              
  Lines       11428    11430       +2     
==========================================
+ Hits        10380    10384       +4     
+ Misses        825      824       -1     
+ Partials      223      222       -1     
Impacted Files Coverage Δ
confmap/provider.go 89.47% <33.33%> (-10.53%) ⬇️
confmap/confmaptest/configtest.go 100.00% <100.00%> (ø)
confmap/resolver.go 92.30% <100.00%> (ø)
pdata/internal/common.go 95.38% <0.00%> (+0.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0cf05e...80ad93a. Read the comment docs.

@bogdandrutu bogdandrutu force-pushed the fixname branch 3 times, most recently from 0a19e1d to 475aefe Compare June 3, 2022 11:53
@bogdandrutu bogdandrutu merged commit 086cc68 into open-telemetry:main Jun 3, 2022
@bogdandrutu bogdandrutu deleted the fixname branch June 3, 2022 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants