Avoid duplicate code, add NewRetrievedFromYAML, replace NewRetrievedFromConf with NewRetrieved #5453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #5453 +/- ##
==========================================
- Coverage 90.89% 90.81% -0.08%
==========================================
Files 191 193 +2
Lines 11419 11419
==========================================
- Hits 10379 10370 -9
- Misses 819 827 +8
- Partials 221 222 +1
Continue to review full report at Codecov.
|
mx-psi
reviewed
Jun 2, 2022
bogdandrutu
force-pushed
the
addnewretfromyaml
branch
3 times, most recently
from
e730d7a to
4483366
Compare
mx-psi
reviewed
Jun 2, 2022
bogdandrutu
force-pushed
the
addnewretfromyaml
branch
2 times, most recently
from
1b37a6f to
72e822c
Compare
bogdandrutu
commented
Jun 2, 2022
bogdandrutu
force-pushed
the
addnewretfromyaml
branch
from
72e822c to
df18291
Compare
…dFromConf * It is ok to rename NewRetrievedFromMap to NewRetrievedFromConf since it was just moved, not yet released. Signed-off-by: Bogdan Drutu <[email protected]>
bogdandrutu
force-pushed
the
addnewretfromyaml
branch
from
df18291 to
8e7ac25
Compare
bogdandrutu
changed the title
|
@mx-psi PTAL |
|
All of them LGTM! :) |
|
All changes are merged from the split PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a step towards supporting providing any value type.
Signed-off-by: Bogdan Drutu [email protected]