-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split model
by signal type and move it to the new pdata
module
#5168
Conversation
73c6730
to
0c365e7
Compare
Codecov Report
@@ Coverage Diff @@
## main #5168 +/- ##
===========================================
- Coverage 90.32% 54.87% -35.46%
===========================================
Files 185 197 +12
Lines 11042 23379 +12337
===========================================
+ Hits 9974 12829 +2855
- Misses 841 9615 +8774
- Partials 227 935 +708
Continue to review full report at Codecov.
|
I'm requesting the review from the same reviewers of the original PR. |
2 questions:
|
The plan is the same. New modules for each signal +
I think we agreed on moving it from |
424c863
to
e56b0f4
Compare
Look like something wrong with coverage calculation. I verified that the coverage is the same between the moved parts |
@dmitryax look into updating this file https://github.com/open-telemetry/opentelemetry-collector/blob/main/.codecov.yml |
Oh that's why! Thanks for pointing on this |
Split all `pdata` related code by type and move it from `model` to the new module `pdata`. - `model/pdata` and `model/otlp` are moved to `pdata/plog`, `pdata/pmetric` and `pdata/ptrace`. - `model/otlpgrpc` is moved to `pdata/plogotlp`, `pdata/pmetricotlp` and `pdata/ptraceotlp`. Now all the API in `model` except for `model/semconv` is deprecated.
🎉 |
Mitigates open-telemetry/opentelemetry-collector#5168 Signed-off-by: Dominik Rosiek <[email protected]>
Mitigates open-telemetry/opentelemetry-collector#5168 Signed-off-by: Dominik Rosiek <[email protected]>
Mitigates open-telemetry/opentelemetry-collector#5168 Signed-off-by: Dominik Rosiek <[email protected]>
Mitigates open-telemetry/opentelemetry-collector#5168 Signed-off-by: Dominik Rosiek <[email protected]>
Mitigates open-telemetry/opentelemetry-collector#5168 Signed-off-by: Dominik Rosiek <[email protected]>
…pen-telemetry#5168) Split all `pdata` related code by type and move it from `model` to the new module `pdata`. - `model/pdata` and `model/otlp` are moved to `pdata/plog`, `pdata/pmetric` and `pdata/ptrace`. - `model/otlpgrpc` is moved to `pdata/plogotlp`, `pdata/pmetricotlp` and `pdata/ptraceotlp`. Now all the API in `model` except for `model/semconv` is deprecated.
Split all
pdata
related code by type and move it frommodel
to the new modulepdata
.model/pdata
andmodel/otlp
are moved topdata/plog
,pdata/pmetric
andpdata/ptrace
.model/otlpgrpc
is moved topdata/plogotlp
,pdata/pmetricotlp
andpdata/ptraceotlp
.Now all the APIs in
model
except formodel/semconv
are deprecated.This is another PR following the latest decisions made in #5087 and #5027.
Resolves #4832 and #5027