refactor: use module per signal type #551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
pmalek-sumo
approved these changes
Apr 19, 2022
| ) | ||
|
|
||
| func TestUInt64ToTraceIDConversion(t *testing.T) { | ||
| assert.Equal(t, | ||
| pdata.NewTraceID([16]byte{0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00}), | ||
| pcommon.NewTraceID([16]byte{0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00}), |
There was a problem hiding this comment.
I wonder why NewTraceID or NewSpanID are not in trace related package 🤔
pmalek-sumo
previously requested changes
Apr 19, 2022
|
Yup, I can 😛 , I need to wait for #550 too |
sumo-drosiek
force-pushed
the
drosiek-bump
branch
from
520e637 to
646b88f
Compare
swiatekm
force-pushed
the
drosiek-bump-changes
branch
from
e68e32c to
be94c01
Compare
Mitigates open-telemetry/opentelemetry-collector#5168 Signed-off-by: Dominik Rosiek <[email protected]>
swiatekm
force-pushed
the
drosiek-bump-changes
branch
from
be94c01 to
631d78f
Compare
swiatekm
requested review from
swiatekm and
pmalek-sumo
and removed request for
pmalek-sumo
swiatekm
approved these changes
Apr 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mitigates open-telemetry/opentelemetry-collector#5168
Depends on: #550
Signed-off-by: Dominik Rosiek [email protected]