Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

memorylimiterprocessor: Remove deprecated config (already no-op) ballast_size_mib #4365

Merged
merged 1 commit into from
Nov 4, 2021

Conversation

bogdandrutu
Copy link
Member

Signed-off-by: Bogdan Drutu [email protected]

@bogdandrutu bogdandrutu requested review from a team and dmitryax November 4, 2021 19:23
@codecov
Copy link

codecov bot commented Nov 4, 2021

Codecov Report

Merging #4365 (dc379b2) into main (7e8cc96) will increase coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4365      +/-   ##
==========================================
+ Coverage   88.29%   88.42%   +0.12%     
==========================================
  Files         176      176              
  Lines       10393    10378      -15     
==========================================
  Hits         9177     9177              
+ Misses        986      971      -15     
  Partials      230      230              
Impacted Files Coverage Δ
processor/memorylimiterprocessor/config.go 100.00% <ø> (ø)
consumer/consumererror/signalerrors.go 100.00% <0.00%> (+35.71%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e8cc96...dc379b2. Read the comment docs.

Copy link
Member

@tigrannajaryan tigrannajaryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we no longer rely on this deprecated feature in Splunk distro of Collector. If I remember correctly you fixed it, did you? Just double checking before we merge this.

@bogdandrutu
Copy link
Member Author

It is a no-op anyway, even if set has no effect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants