[processor/memorylimiter] Remove deprecated ballast_size_mib config from examples #9085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
jpkrohling
approved these changes
Apr 5, 2022
mar4uk
force-pushed
the
memorylimiterprocessor-fix-usage-in-examples
branch
from
08630c4 to
d470448
Compare
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: memorylimiter parameter ballast_size_mib was deprecated and is not supported anymore open-telemetry/opentelemetry-collector#4365.
Examples for lokiexporter, sapmexporter were not correct. In case of lokiexporter it was not possible to run otel-collector because config used deprecated ballast_size_mib key.
Also fixed typo in exporters/lokiexporter/example/otel-collector-config.yaml
resources -> resourceTesting: ran make before commit, ran
docker-compose up otel-collector -din exporters/lokiexporter/example to check that container starts correctlyFixes: #9067