Use assert/require in test code of exporter #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huikang
requested review from
bogdandrutu,
flands,
pjanotti,
songy23 and
tigrannajaryan
as code owners
huikang
force-pushed
the
use-assert-in-test
branch
from
4c1e3de to
c49b8a0
Compare
Codecov Report
@@ Coverage Diff @@
## master #286 +/- ##
=======================================
Coverage 73.13% 73.13%
=======================================
Files 111 111
Lines 6446 6446
=======================================
Hits 4714 4714
Misses 1488 1488
Partials 244 244Continue to review full report at Codecov.
|
Signed-off-by: Hui Kang <[email protected]>
huikang
force-pushed
the
use-assert-in-test
branch
from
c49b8a0 to
16ee12f
Compare
pjanotti
approved these changes
Aug 23, 2019
MovieStoreGuy
pushed a commit
to atlassian-forks/opentelemetry-collector
that referenced
this pull request
Nov 11, 2021
* set attributes in tracer.Start() * add tests * remove no longer needed attribute additions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#266
Signed-off-by: Hui Kang [email protected]