Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate code base to use "github.com/stretchr/testify/assert" #266

Closed
ccaraman opened this issue Aug 15, 2019 · 4 comments
Closed
Assignees
Labels
good first issue Good for newcomers help wanted Good issue for contributors to OpenTelemetry Service to pick up

Comments

@ccaraman
Copy link
Contributor

Currently there are parts of the code base that still use the pattern

if <some property> != <expected property> {
  t.Fatalf("...")
}

Migrate these instances to use
assert.* in place of this pattern.

@pjanotti pjanotti added good first issue Good for newcomers help wanted Good issue for contributors to OpenTelemetry Service to pick up up-for-grabs labels Aug 16, 2019
@pjanotti
Copy link
Contributor

It doesn't need to be done all at once, PRs doing it partially are helpful.

@huikang
Copy link
Member

huikang commented Aug 21, 2019

Hi, @ccaraman @pjanotti , I'd like to try working on this issue. If no one has taken it, please assign it to me. Thanks.

@tigrannajaryan
Copy link
Member

@huikang assigned to you, thank you.

huikang pushed a commit to huikang/opentelemetry-collector that referenced this issue Aug 21, 2019
huikang pushed a commit to huikang/opentelemetry-collector that referenced this issue Aug 21, 2019
@ccaraman
Copy link
Contributor Author

@huikang Let us know if you have any questions!

huikang pushed a commit to huikang/opentelemetry-collector that referenced this issue Aug 22, 2019
tigrannajaryan pushed a commit that referenced this issue Aug 22, 2019
tomaszpiekarczyk added a commit to tomaszpiekarczyk/opentelemetry-collector that referenced this issue Jun 25, 2020
tomaszpiekarczyk added a commit to tomaszpiekarczyk/opentelemetry-collector that referenced this issue Jun 25, 2020
tomaszpiekarczyk added a commit to tomaszpiekarczyk/opentelemetry-collector that referenced this issue Jun 25, 2020
tomaszpiekarczyk added a commit to tomaszpiekarczyk/opentelemetry-collector that referenced this issue Jun 25, 2020
tomaszpiekarczyk added a commit to tomaszpiekarczyk/opentelemetry-collector that referenced this issue Jun 25, 2020
wyTrivail pushed a commit to mxiamxia/opentelemetry-collector that referenced this issue Jul 13, 2020
hughesjj pushed a commit to hughesjj/opentelemetry-collector that referenced this issue Apr 27, 2023
Troels51 pushed a commit to Troels51/opentelemetry-collector that referenced this issue Jul 5, 2024
swiatekm pushed a commit to swiatekm/opentelemetry-collector that referenced this issue Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Good issue for contributors to OpenTelemetry Service to pick up
Projects
None yet
Development

No branches or pull requests

5 participants