Passthrough CORS allowed origins #260
Conversation
backjo
requested review from
bogdandrutu,
flands,
pjanotti,
songy23 and
tigrannajaryan
as code owners
Codecov Report
@@ Coverage Diff @@
## master #260 +/- ##
=========================================
- Coverage 73.13% 73.1% -0.03%
=========================================
Files 110 110
Lines 6383 6385 +2
=========================================
Hits 4668 4668
- Misses 1476 1477 +1
- Partials 239 240 +1
Continue to review full report at Codecov.
|
| @@ -68,9 +68,6 @@ The full list of settings exposed for this receiver are documented [here](https: | |||
| with detailed sample configurations [here](https://github.com/open-telemetry/opentelemetry-service/blob/master/receiver/opencensusreceiver/testdata/config.yaml). | |||
|
|
|||
| ### Writing with HTTP/JSON | |||
| // TODO(ccaraman) The cors setting wasn't ported accidentally. In a follow up | |||
There was a problem hiding this comment.
The next line is a bit outdated, like referring to OpenCensus. Could you reword it to mention Otel and make it clearer that the receiver handles both HTTP and gRPC.
There was a problem hiding this comment.
A bit unclear here - is calling it the OpenCensus receiver incorrect? My understanding was that it's still being referred to as the OpenCensus receiver inside of Otel
There was a problem hiding this comment.
🤦♀ apologies my coffee is fading and rereading it a few more times I see that I was thinking about it in the wrong context.
Ignore this comment!
|
Thanks @backjo ! |
Addresses #243