Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OC Receiver: Add Cors functionality #243

Closed
ccaraman opened this issue Aug 7, 2019 · 1 comment
Closed

OC Receiver: Add Cors functionality #243

ccaraman opened this issue Aug 7, 2019 · 1 comment

Comments

@ccaraman
Copy link
Contributor

ccaraman commented Aug 7, 2019

Cors functionality accidentally got removed during the port to OtelSvc. This issue tracks adding it.
https://github.com/census-instrumentation/opencensus-service/blob/master/receiver/opencensusreceiver/opencensus.go#L47

Link to TODO's in OtelSvc code base:
https://github.com/open-telemetry/opentelemetry-service/blob/4a1cc81970b8bb8e64471cdb9d7a3b08b9e21015/receiver/opencensusreceiver/config.go#L44-L45
@backjo backjo mentioned this issue Aug 14, 2019
Merged
@ccaraman
Copy link
Contributor Author

This got fixed with #260 closing this issue.

MovieStoreGuy pushed a commit to atlassian-forks/opentelemetry-collector that referenced this issue Nov 11, 2021
@lizthegrey @rghetia
Specify a version of otel base repo (open-telemetry#243)
d9c4aa5 
Otherwise, this results:

```
go: finding go.opentelemetry.io latest
go: finding go.opentelemetry.io/exporter/trace/jaeger latest
go: go.opentelemetry.io/exporter/trace/[email protected] requires
	[email protected]: invalid version: unknown revision 000000000000
```
hughesjj pushed a commit to hughesjj/opentelemetry-collector that referenced this issue Apr 27, 2023
@rmfitzpatrick
Better document and test SA Extension config (open-telemetry#243)
2a6038e
Troels51 pushed a commit to Troels51/opentelemetry-collector that referenced this issue Jul 5, 2024
Add int32_t support for SpanData attributes (open-telemetry#243)
7711f73
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ccaraman