mdatagen: NewTelemetryBuilder does nil check #11687
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the NewTelemetryBuilder function would panic if the LeveledMeterProvider function wasn't specified in the settings. This PR adds a nil check to that function, as well as a test that it responds with an error rather than panicking.
|
Thanks for letting me know @bogdandrutu, I will close this PR and the issue as obsolete. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11687 +/- ##
=======================================
Coverage 91.64% 91.64%
=======================================
Files 442 442
Lines 23746 23770 +24
=======================================
+ Hits 21761 21785 +24
Misses 1616 1616
Partials 369 369 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, the NewTelemetryBuilder function would panic if the LeveledMeterProvider function wasn't specified in the settings. This PR adds a nil check to that function, as well as a test that it responds with an error rather than panicking.
Link to tracking issue
Fixes #11684
Testing
make gogeneratemake gotestDocumentation